ci/format: Remove ~unused CI format test (#35986)

this test was never really run as `CI_BRANCH` is not automatically set in azp now the thing its testing has moved to bazel so the test is not really correct also im in the process of moving the thing being tested to toolshed (where it will be testsed more comprehensively) Signed-off-by: Ryan Northey <[email protected]>
envoyproxy · Sep 5, 2024 · 5c70114 · 5c70114
1 parent 8cd8c3d
commit 5c70114
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 358 deletions.
diff --git a/ci/format_pre.sh b/ci/format_pre.sh
@@ -58,12 +58,6 @@ bazel "${BAZEL_STARTUP_OPTIONS[@]}" run "${BAZEL_BUILD_OPTIONS[@]}" //configs:ex
 CURRENT=spelling
 "${ENVOY_SRCDIR}/tools/spelling/check_spelling_pedantic.py" --mark check
 
-# TODO(phlax): move clang/buildifier checks to bazel rules (/aspects)
-if [[ -n "$CI_BRANCH" ]]; then
-    CURRENT=check_format_test
-    "${ENVOY_SRCDIR}/tools/code_format/check_format_test_helper.sh" --log=WARN
-fi
-
 CURRENT=check_format
 bazel "${BAZEL_STARTUP_OPTIONS[@]}" run "${BAZEL_BUILD_OPTIONS[@]}" //tools/code_format:check_format -- fix --fail_on_diff
 

diff --git a/tools/code_format/check_format_test.sh b/tools/code_format/check_format_test.sh
diff --git a/tools/code_format/check_format_test_helper.py b/tools/code_format/check_format_test_helper.py
diff --git a/tools/code_format/check_format_test_helper.sh b/tools/code_format/check_format_test_helper.sh