Skip to content

Commit

Permalink
ext_proc: Fix the flaky test
Browse files Browse the repository at this point in the history
Signed-off-by: tyxia <[email protected]>
  • Loading branch information
tyxia committed Jul 20, 2024
1 parent 98da806 commit 1f11742
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1599,8 +1599,7 @@ TEST_P(ExtProcIntegrationTest, GetAndSetHeadersAndTrailersOnResponse) {
// Test the filter using the default configuration by connecting to
// an ext_proc server that tries to modify the trailers incorrectly
// according to the header mutation rules.
// TODO(tyxia): re-enable this test (see https://github.com/envoyproxy/envoy/issues/35281)
TEST_P(ExtProcIntegrationTest, DISABLED_GetAndSetTrailersIncorrectlyOnResponse) {
TEST_P(ExtProcIntegrationTest, GetAndSetTrailersIncorrectlyOnResponse) {
proto_config_.mutable_processing_mode()->set_response_trailer_mode(ProcessingMode::SEND);
proto_config_.mutable_mutation_rules()->mutable_disallow_all()->set_value(true);
proto_config_.mutable_mutation_rules()->mutable_disallow_is_error()->set_value(true);
Expand All @@ -1620,6 +1619,7 @@ TEST_P(ExtProcIntegrationTest, DISABLED_GetAndSetTrailersIncorrectlyOnResponse)
});

if (Runtime::runtimeFeatureEnabled(Runtime::defer_processing_backedup_streams)) {
timeSystem().advanceTimeWait(TestUtility::DefaultTimeout);
// We get a reset since we've received some of the response already.
ASSERT_TRUE(response->waitForReset());
} else {
Expand Down

0 comments on commit 1f11742

Please sign in to comment.