ext_authz: remove unnecessary shared pointer copies (#36014)

Commit Message: remove unnecessary shared pointer copies from ext authz filter factory Additional Description: - Risk Level: low Testing: - Docs Changes: - Release Notes: - Platform Specific Features: - Signed-off-by: antoniovleonti <[email protected]>
envoyproxy · Sep 9, 2024 · 1da76eb · 1da76eb
1 parent a01c046
commit 1da76eb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/source/extensions/filters/http/ext_authz/config.cc b/source/extensions/filters/http/ext_authz/config.cc
@@ -35,7 +35,7 @@ Http::FilterFactoryCb ExtAuthzFilterConfig::createFilterFactoryFromProtoWithServ
     const auto client_config =
         std::make_shared<Extensions::Filters::Common::ExtAuthz::ClientConfig>(
             proto_config, timeout_ms, proto_config.http_service().path_prefix(), server_context);
-    callback = [filter_config, client_config,
+    callback = [filter_config = std::move(filter_config), client_config,
                 &server_context](Http::FilterChainFactoryCallbacks& callbacks) {
       auto client = std::make_unique<Extensions::Filters::Common::ExtAuthz::RawHttpClientImpl>(
           server_context.clusterManager(), client_config);
@@ -48,7 +48,7 @@ Http::FilterFactoryCb ExtAuthzFilterConfig::createFilterFactoryFromProtoWithServ
     THROW_IF_NOT_OK(Config::Utility::checkTransportVersion(proto_config));
     Envoy::Grpc::GrpcServiceConfigWithHashKey config_with_hash_key =
         Envoy::Grpc::GrpcServiceConfigWithHashKey(proto_config.grpc_service());
-    callback = [&server_context, filter_config, timeout_ms,
+    callback = [&server_context, filter_config = std::move(filter_config), timeout_ms,
                 config_with_hash_key](Http::FilterChainFactoryCallbacks& callbacks) {
       auto client_or_error = server_context.clusterManager()
                                  .grpcAsyncClientManager()