Skip to content

Commit

Permalink
fix flaky direct response test in tsan mode (#35261)
Browse files Browse the repository at this point in the history
Signed-off-by: wbpcode <[email protected]>
  • Loading branch information
code authored Jul 18, 2024
1 parent af6c1e4 commit 1af0029
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion test/integration/direct_response_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,11 @@ TEST_P(DirectResponseIntegrationTest, DefaultDirectResponseBodySize) {
TEST_P(DirectResponseIntegrationTest, DirectResponseBodySizeLarge) {
// Test with a large direct response body size, and with constrained buffer limits.
config_helper_.setBufferLimits(1024, 1024);
testDirectResponseBodySize(1000 * 4096);
// Envoy takes much time to load the big configuration in TSAN mode and will result in the test to
// be flaky. See https://github.com/envoyproxy/envoy/issues/33957 for more detail and context.
// We reduce the body size from 4MB to 2MB to reduce the size of configuration to make the CI more
// stable.
testDirectResponseBodySize(/*1000*/ 500 * 4096);
}

TEST_P(DirectResponseIntegrationTest, DirectResponseBodySizeSmall) {
Expand Down

0 comments on commit 1af0029

Please sign in to comment.