Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Button to Reset Settings in SettingScreen #978

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SanjaySargam
Copy link
Contributor

Fixes #447

Screen Recording

reset.mp4

@SanjaySargam SanjaySargam changed the base branch from develop to master March 6, 2023 19:28
@SebaDro
Copy link
Contributor

SebaDro commented Jul 25, 2023

Hi @SanjaySargam . Many thanks for your contribution. I like the new resetting feature since it increases user experience and users won't have to reset every single setting. However, I'd suggest following improvements before considering it for merge:

  1. The button is not highlighted enough, so users may oversee it. Please, check the style of other UI controls in the app and use the same for the reset button.
  2. I think the button should be moved to the bottom of the screen. It feels a little bit misplaced in the top. Maybe, implement sticky behaviour, but I'm not sure about and open for suggestions about the right place.
  3. Before applying a reset the user should be asked again, if he is sure about it. Just show a MaterialAlertDialog, which asks the user about it. Please, also have a look how other Dialogs are styled and implemented in the app and adopt it for your one.

What do you think about it? Will you work on it?

@SanjaySargam
Copy link
Contributor Author

What do you think about it? Will you work on it?

@SebaDro Yeah Sure. I'll work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to reset settings in the Settings screen
2 participants