Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced Otto event bus library with RxJava event bus #941

Open
wants to merge 1 commit into
base: gsoc2022
Choose a base branch
from
Open

Replaced Otto event bus library with RxJava event bus #941

wants to merge 1 commit into from

Conversation

Akash-Ramjyothi
Copy link
Contributor

Fixes: #827.

Description:

  • Replaced the deprecated Otto event bus library with RxJava event bus.
  • Best option for getting asynchronous data requests from APIs.
  • It simplifies the communication between components and avoids decouples event senders and receivers.

@Akash-Ramjyothi
Copy link
Contributor Author

@asaikarthikeya please see my PR.

@SebaDro
Copy link
Contributor

SebaDro commented Sep 22, 2022

The introduced RxBus lib does not seem to be well maintained. What's the benefit of this lib over the Otto event bus library? If we depend on a library that won't be maintained well and maybe deprecated in the future, we do not win anything. What about other libs, such as greenrobot/EventBus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement GSoC Needs discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akash-Ramjyothi @SebaDro