Remove declare synced #1134
Remove declare synced #1134
Conversation
pallets/staking/src/benchmarking.rs
Outdated
| @@ -272,7 +272,7 @@ benchmarks! { | |||
| let block_number = 1; | |||
| let nonce = NULL_ARR; | |||
| let x25519_public_key = NULL_ARR; | |||
| let endpoint = b"http://localhost:3001".to_vec(); | |||
| let endpoint = vec![]; | |||
There was a problem hiding this comment.
so there are two ways to run benches
compile then run them (like in our scripts) this is the more closer to production way
or the easier way run them with cargo test --features=runtime-benchmarks
the first uses the runtime config sets
the second uses the mocks
So this would pass the first not the second, now it passes both
There was a problem hiding this comment.
@JesseAbram I thought I bumped the max length to account for this, no? If not, can you bump it to like 25 bytes, it helps makes the test more readable.
There was a problem hiding this comment.
mmm pretty sure that would effect other tests
There was a problem hiding this comment.
Ah sorry, I did change this but in #1123 which is still a draft PR 😅
pallets/staking/src/lib.rs
Outdated
| Self::deposit_event(Event::ValidatorSyncStatus(stash, synced)); | ||
| Ok(()) | ||
| } | ||
|
|
||
| #[pallet::call_index(7)] |
There was a problem hiding this comment.
We might as well bite the bullet here and make it a transaction_version bump by changing this to 6
pallets/registry/src/benchmarking.rs
Outdated
| @@ -48,7 +48,6 @@ fn assert_last_event<T: Config>(generic_event: <T as Config>::RuntimeEvent) { | |||
|
|
|||
| pub fn add_non_syncing_validators<T: Config>( | |||
There was a problem hiding this comment.
Can we rename this then to just add_validators?
HCastano
added
the
Bump `transaction_version`
This is a holdover of subgroups, validators are immediately synced as there is only one parent key