Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single line for release checklist command #1106

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

vitropy
Copy link
Contributor

@vitropy vitropy commented Oct 8, 2024

The backslash, when treated literally, will cause the entropy-test-cli to fail to load its subcommand. In Markdown, this should either have been written as:

the command \
    with a new line

or just remove the slash and leave the single-line code formatting. I propose this simpler, latter option.

The backslash, when treated literally, will cause the `entropy-test-cli` to fail to load its subcommand. In Markdown, this should either have been written as:

```
the command \
    with a new line
```

or just remove the slash and leave the single-line code formatting. I propose this simpler, latter option.
Copy link
Collaborator

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the split line approach, but in this case since it's not too long a line it's fine.

Can you also update the signature command below to match?

Thanks!

@HCastano HCastano merged commit ba0bfef into master Oct 9, 2024
7 checks passed
@HCastano HCastano deleted the vi/checklist-formatting branch October 9, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants