Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for new_session hook #1016

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Commits on Aug 19, 2024

  1. Benchmark for new session

    JesseAbram committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5fa6a24 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Configuration menu
    Copy the full SHA
    d5efccd View commit details
    Browse the repository at this point in the history
  2. new_session weight

    JesseAbram committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    157b888 View commit details
    Browse the repository at this point in the history
  3. lint

    JesseAbram committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9555684 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Suggestions for new_session benches (#1019)

    * Format benchmarking code
    
    * Update `*_less_then_signers` bench to scale signers in storage
    
    Since we end up reading from this storage vec we want to make sure it is populated with up to
    `MAX_SIGNERS` for the purposes of benchmarking.
    
    * Change benchmarking for session handler to only use two benches
    
    We add an extra storage read each time, but we can simplify the benchmarking a bit
    
    * Always update session weight
    
    If the signer length was more than the total signers we wouldn't
    update the session weight, even though we would still do a few
    storage operations.
    
    * Remove `expect` by using `match` statement
    
    * Remove unused `new_session_not_adding_new_signer` bench
    
    * Update the name for one of the benches
    
    * Update benchmark results
    
    * Add missing parameter to base bench
    HCastano authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7b4254b View commit details
    Browse the repository at this point in the history