Use pip install instead of the deprecated python setup.py install #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This worked. We're getting warnings about using outdated actions, but those can be fixed separately. @corranwebster Would you be available for a quick review? |
corranwebster
approved these changes
Mar 1, 2024
mdickinson
added a commit
that referenced
this pull request
Mar 8, 2024
We're getting warnings about outdated GitHub Actions. This PR brings all actions up to the most recent versions. ~I'm not yet sure whether it's safe to remove the use of GabrielBB/xvfb-action@v1 altogether or whether we need to introduce an explicit use of `xvfb-run -a` on Ubuntu workers. Testing that workflow is currently blocked by the `python setup.py install` failure fixed in #182.~ Update: #182 is merged, and it looks as though everything's working despite the removal of the xvfb-action. Test run: https://github.com/enthought/scimath/actions/runs/8112365378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our bleeding edge tests are failing. This PR may fix that.
Test run: https://github.com/enthought/scimath/actions/runs/8111735158