-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce priority queue-based policy again #81
Conversation
Conflicts: simplesat/sat/policy.py
Is this PR still relevant following our recent discussions ? |
There are a few major differences between this policy and the current
This could also be simplified by not sorting packages topologically. It was an experiment that does seem to reduce the number of suggestions required overall, but doesn't affect the quality of the result. I think this policy has value, but I would also understand not wanting to bring in code that is arguably no longer solving a concrete problem after #78. |
Let's keep this opened for now, I will look at it when I have some time |
There are probably some parts of this that could be used to improve |
I'm going to split up the |
Another remake of #65, #55.
The notes listed in those issues still apply.
An additional trick that this policy does is attempt to minimize the number of suggestions required by suggesting packages at the top of the dependency tree first. This causes many more assignments to be made via unit propagation. For scenarios like
epd_full_upgrade
this can cut the number of suggestions needed significantly.Timings are for
epd_full_upgrade
and should be comparable to #78.Master
This branch