Skip to content

Commit

Permalink
image_name and app_id are redundant; use app_id because that's better…
Browse files Browse the repository at this point in the history
… for the CLI
  • Loading branch information
EdwinWiseOne committed Sep 6, 2024
1 parent 04066e8 commit a173b3d
Show file tree
Hide file tree
Showing 10 changed files with 15 additions and 20 deletions.
3 changes: 1 addition & 2 deletions Minimal/app_config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
image_name: edge-minimal-example
app_id: edge-minimal-example
framework: generic
app_id: null
app_version: 1.2.0
python_version: 3.8
repository: quay.io
Expand Down
4 changes: 2 additions & 2 deletions Minimal/ci/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def _bundle_image(config: dict) -> str:
"""
return "/".join([config["repository"],
config["organisation"],
config["image_name"]])
config["app_id"]])


@click.group()
Expand Down Expand Up @@ -86,7 +86,7 @@ def run(config, bundle_image, verbose):

# Configuration details
bundle_image = bundle_image or _bundle_image(config)
container_name = config["image_name"]
container_name = config["app_id"]
version = config["app_version"]

# Get values from the dev settings file (API tokens for testing, etc.)
Expand Down
3 changes: 1 addition & 2 deletions Panel/app_config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
image_name: edge-panel-example
app_id: edge-panel-example
framework: panel
app_id: null
app_version: 1.3.0
python_version: 3.8
repository: quay.io
Expand Down
4 changes: 2 additions & 2 deletions Panel/ci/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def _bundle_image(config: dict) -> str:
"""
return "/".join([config["repository"],
config["organisation"],
config["image_name"]])
config["app_id"]])


@click.group()
Expand Down Expand Up @@ -86,7 +86,7 @@ def run(config, bundle_image, verbose):

# Configuration details
bundle_image = bundle_image or _bundle_image(config)
container_name = config["image_name"]
container_name = config["app_id"]
version = config["app_version"]

# Get values from the dev settings file (API tokens for testing, etc.)
Expand Down
3 changes: 1 addition & 2 deletions Plotly Dash/app_config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
image_name: edge-plotly-dash-example
app_id: edge-plotly-dash-example
framework: plotly-dash
app_id: null
app_version: 1.3.0
python_version: 3.8
repository: quay.io
Expand Down
4 changes: 2 additions & 2 deletions Plotly Dash/ci/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def _bundle_image(config: dict) -> str:
"""
return "/".join([config["repository"],
config["organisation"],
config["image_name"]])
config["app_id"]])


@click.group()
Expand Down Expand Up @@ -86,7 +86,7 @@ def run(config, bundle_image, verbose):

# Configuration details
bundle_image = bundle_image or _bundle_image(config)
container_name = config["image_name"]
container_name = config["app_id"]
version = config["app_version"]

# Get values from the dev settings file (API tokens for testing, etc.)
Expand Down
3 changes: 1 addition & 2 deletions React/app_config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
image_name: edge-react-example
app_id: edge-react-example
framework: react
app_id: null
app_version: 1.3.0
python_version: 3.8
repository: quay.io
Expand Down
4 changes: 2 additions & 2 deletions React/ci/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def _bundle_image(config: dict) -> str:
"""
return "/".join([config["repository"],
config["organisation"],
config["image_name"]])
config["app_id"]])


@click.group()
Expand Down Expand Up @@ -91,7 +91,7 @@ def run(config, bundle_image, verbose):

# Configuration details
bundle_image = bundle_image or _bundle_image(config)
container_name = config["image_name"]
container_name = config["app_id"]
version = config["app_version"]

# Get values from the dev settings file (API tokens for testing, etc.)
Expand Down
3 changes: 1 addition & 2 deletions Streamlit/app_config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
image_name: edge-streamlit-example
app_id: edge-streamlit-example
framework: streamlit
app_id: null
app_version: 1.3.0
python_version: 3.8
repository: quay.io
Expand Down
4 changes: 2 additions & 2 deletions Streamlit/ci/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def _bundle_image(config: dict) -> str:
"""
return "/".join([config["repository"],
config["organisation"],
config["image_name"]])
config["app_id"]])


@click.group()
Expand Down Expand Up @@ -86,7 +86,7 @@ def run(config, bundle_image, verbose):

# Configuration details
bundle_image = bundle_image or _bundle_image(config)
container_name = config["image_name"]
container_name = config["app_id"]
version = config["app_version"]

# Get values from the dev settings file (API tokens for testing, etc.)
Expand Down

0 comments on commit a173b3d

Please sign in to comment.