Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix offchain dns nametype + [root] validation #700

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

storywithoutend
Copy link
Collaborator

User reported a bug where "sync manager" button appeared on his off-chain dns name. The source of the bug was that he also began the process of on-chain import by setting his dns-owner record.

Additional fix in this PR fixes the profile page for [root] where the invalid name warning and isNonASCII warning were showing.

This PR:

  • Updates useNameType hook to check for ownerData before assigning on-chain dns name type.
  • Adds additional unit tests for useNameType
  • Fixes validation for [root] where isNonASCII is now false
  • Fixes registrationStatus for [root] where it is now "owned" instead of "invalid"

Copy link

cloudflare-workers-and-pages bot commented Mar 29, 2024

Deploying ens-app-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 77e67f1
Status: ✅  Deploy successful!
Preview URL: https://7583d003.ens-app-v3.pages.dev
Branch Preview URL: https://fix-offchain-dns-sync-manage.ens-app-v3.pages.dev

View logs

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
33.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants