fix: safe tx support #522
Merged
fix: safe tx support #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
9e5b303
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dfdca65d.ens-app-v3.pages.dev |
| Branch Preview URL: | https://fix-safe-support.ens-app-v3.pages.dev |
Current Cypress Test Results Summary✅ 105 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/20/2023 01:51:22am UTC) Run DetailsRunning Workflow Test on Github Actions Commit: 9e5b303 Started: 06/20/2023 01:37:26am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Set Primary Name from settings subgraph errors should disable button for wrapped subname in profile
Retry 1 • Initial Attempt |
0% (0)0 / 32 runsfailed over last 7 days |
100% (32)32 / 32 runsflaked over last 7 days |
📄 e2e/specs/stateless/08_registerName.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Register Name should allow normal registration
Retry 1 • Initial Attempt |
5.36% (3)3 / 56 runsfailed over last 7 days |
94.64% (53)53 / 56 runsflaked over last 7 days |
Current Cypress Test Results Summary
✅ 16 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 06/20/2023 01:51:22am UTC)
Run Details
Running Workflow Test on Github Actions
Commit: 9e5b303
Started: 06/20/2023 01:37:32am UTC
⚠️ Flakes
📄 e2e/specs/stateful/03_dnsclaim.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Import DNSSEC name should allow user to import a domain that they are not the owner of
Retry 1 • Initial Attempt |
0% (0)0 / 55 runsfailed over last 7 days |
3.64% (2)2 / 55 runsflaked over last 7 days |
LeonmanRolls
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
isSafeTxproperty to the tx store itemsonSuccess()after sending a transactionwaitForTransaction()function that has special handling for safe txs (attempts to fetch from the SAFE api)fix works with both walletconnect and SAFE web
Fixes FET-1241