Merge pull request #524 from ensdomains/fix/outlink-externals

fix: target _blank for external links
ensdomains · Jun 16, 2023 · 3245df3 · 3245df3
2 parents c8ccd08 + 1e1aa63
commit 3245df3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/components/@molecules/Hamburger/MainMenu.tsx b/src/components/@molecules/Hamburger/MainMenu.tsx
@@ -302,7 +302,7 @@ const MainMenu = ({
           }
           return (
             <BaseLink href={route.href} passHref key={route.href}>
-              <RouteItem>
+              <RouteItem {...(route.href.startsWith('http') ? { target: '_blank' } : {})}>
                 <Typography>{t(route.label)}</Typography>
               </RouteItem>
             </BaseLink>

diff --git a/src/components/SocialIcon.tsx b/src/components/SocialIcon.tsx
@@ -51,7 +51,7 @@ export const SocialIcon = ({
   href: string
 }) => {
   return (
-    <SocialIconWrapper href={href}>
+    <SocialIconWrapper href={href} target="_blank">
       <StyledIcon key={href} $iconColor={color} as={Icon} />
       {ColoredIcon && <StyledColoredIcon as={ColoredIcon} />}
     </SocialIconWrapper>