-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Expo 49 & expo-blur 12.4.1 ( with needed fixes for breaking changes ) #112
base: main
Are you sure you want to change the base?
Conversation
awesome this works perfectly for me! thank you for publishing your latest changes :) FYI I didn't need to apply that react-native-reanimated patch to get it to work but maybe i will run into the error later on |
Maybe they merged the changes to the latest version? which version of reanimated are you using? |
Hmm I'm using thanks again for your work on this! |
Please merge this great PR maintainers 🙏 @enesozturk @kesha-antonov @gorhom @spencerc99 |
Hey maintainers, this seems to fix the issue. Please review and approve it when you get the time. |
@enesozturk please review changes, we also need rn-hold-menu in our project with expo 49+ and reanimated 3+ |
@marcdelalonde Did you try the reanimated patch I mentioned above? |
Please merge 🙏 |
Thanks for the work done! Looking forward at this to be merged 😄 |
@enesozturk could we merge this? 🙏 the package is currently broken and this should fix it. |
Hello 👋
closes: #111
There have been breaking changes with Expo 49 &
expo-blur
12.4.1
see: expo/expo#23539This PR bump expo + expo package versions and fix related breaking changes.
Unfortunately this library also breaks with reanimated 3.3.0 and 3.4.0. Not sure if it works with later versions or not. But there was a problem with assigning functions to a reanimated shared value ( when you try to read function after words it's always empty object) I could fix that with these changes that I found here: