Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing credential field is not required #177

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix: fixing credential field is not required #177

merged 1 commit into from
Sep 8, 2023

Conversation

artursudnik
Copy link
Member

This PR fixes credential field is not required by the POST /v1/vc-api/credentials/issue and as a result https://w3c-ccg.github.io/vc-api-issuer-test-suite/ failing.

@artursudnik artursudnik self-assigned this Sep 8, 2023
jrhender
jrhender approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@jrhender jrhender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks 👍

@jrhender jrhender merged commit 6fdc7b0 into develop Sep 8, 2023
2 checks passed
@artursudnik artursudnik deleted the fix/fixing-credential-should-be-required branch September 8, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhender jrhender jrhender approved these changes

Assignees

@artursudnik artursudnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artursudnik @jrhender