bug/swtch-3035 Not valid VC are verified #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGiter
commented
Jul 12, 2024
src/modules/claims/claims.service.ts
Outdated
| } | ||
| issuerVerified = issuerVerified && issuerVerificationResult.verified; |
There was a problem hiding this comment.
issuerVerified is also used as result of status verification, so the final issuerVerified is boolean AND of both checks. Perhaps this checks should be separated
|
The CI is not passing, but it is something wrong with setting up ipfs as locally tests are passing if I run them separately. The exception is |
jrhender
reviewed
Jul 17, 2024
JGiter
force-pushed
the
bug/not-valid-vc-verified
branch
2 times, most recently
from
3f8fd29
to
7357300
Compare
jrhender
approved these changes
Jul 18, 2024
Co-authored-by: John Henderson <[email protected]>
|
🎉 This PR is included in version 8.1.1-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 8.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checks issuer verification result
Contributor checklist