fix: check issuer verification result

energywebfoundation · Jul 12, 2024 · 5c52191 · 5c52191
1 parent 880ae80
commit 5c52191
Show file tree

Hide file tree

Showing 6 changed files with 47 additions and 37 deletions.
diff --git a/docs/api/classes/modules_signer.SignerService.md b/docs/api/classes/modules_signer.SignerService.md
@@ -353,14 +353,14 @@ ___
 
 Add event handler for certain events
 
-#### Returns
-
-`void`
-
 **`Requires`**
 
 to be called after the connection to wallet was initialized
 
+#### Returns
+
+`void`
+
 ___
 
 ### on

diff --git a/docs/api/classes/modules_staking.StakingFactoryService.md b/docs/api/classes/modules_staking.StakingFactoryService.md
@@ -35,28 +35,28 @@ Intended for staking pool
 
 ▸ **allServices**(): `Promise`<[`Service`](../modules/modules_staking.md#service)[]\>
 
-#### Returns
-
-`Promise`<[`Service`](../modules/modules_staking.md#service)[]\>
-
 **`Description`**
 
 Returns all services for which pools are launched
 
+#### Returns
+
+`Promise`<[`Service`](../modules/modules_staking.md#service)[]\>
+
 ___
 
 ### getPool
 
 ▸ **getPool**(): `Promise`<[`StakingPoolService`](modules_staking.StakingPoolService.md)\>
 
-#### Returns
-
-`Promise`<[`StakingPoolService`](modules_staking.StakingPoolService.md)\>
-
 **`Description`**
 
 Returns pool launched for energyweb org
 
+#### Returns
+
+`Promise`<[`StakingPoolService`](modules_staking.StakingPoolService.md)\>
+
 ___
 
 ### create

diff --git a/docs/api/classes/modules_staking.StakingPoolService.md b/docs/api/classes/modules_staking.StakingPoolService.md
@@ -127,6 +127,8 @@ ___
 
 ▸ **partialWithdraw**(`value`): `Promise`<`ContractReceipt`\>
 
+**`Description`**
+
 #### Parameters
 
 | Name | Type |
@@ -137,14 +139,20 @@ ___
 
 `Promise`<`ContractReceipt`\>
 
-**`Description`**
-
 ___
 
 ### putStake
 
 ▸ **putStake**(`stake`): `Promise`<`void`\>
 
+**`Description`**
+
+Locks stake and starts accumulating reward
+
+**`Emits`**
+
+StakingPool.StakePut
+
 #### Parameters
 
 | Name | Type |
@@ -155,24 +163,16 @@ ___
 
 `Promise`<`void`\>
 
-**`Description`**
-
-Locks stake and starts accumulating reward
-
-**`Emits`**
-
-StakingPool.StakePut
-
 ___
 
 ### withdraw
 
 ▸ **withdraw**(): `Promise`<`void`\>
 
-#### Returns
-
-`Promise`<`void`\>
-
 **`Description`**
 
 pays back stake with accumulated reward.
+
+#### Returns
+
+`Promise`<`void`\>
diff --git a/.../api/classes/modules_verifiable_credentials.VerifiableCredentialsServiceBase.md b/.../api/classes/modules_verifiable_credentials.VerifiableCredentialsServiceBase.md
@@ -50,6 +50,10 @@ verifiableCredentialsService.createRoleVC(...);
 
 ▸ **continueExchange**(`«destructured»`): `Promise`<`undefined` \| `VerifiablePresentation` \| `VpRequest`\>
 
+**`Description`**
+
+Sends credentials requested by issuer and returns either issued credentials or next credentials request
+
 #### Parameters
 
 | Name | Type |
@@ -62,10 +66,6 @@ verifiableCredentialsService.createRoleVC(...);
 
 issued credentials or request of additional credentials
 
-**`Description`**
-
-Sends credentials requested by issuer and returns either issued credentials or next credentials request
-
 ___
 
 ### createCredential

diff --git a/docs/api/modules/modules_signer.md b/docs/api/modules/modules_signer.md
@@ -106,6 +106,11 @@ ___
 
 ▸ **fromGnosis**(`safeAppSdk`): `Promise`<[`SignerService`](../classes/modules_signer.SignerService.md)\>
 
+**`Description`**
+
+Intended for use in Volta Gnosis web interface(https://volta.gnosis-safe.io/).
+Dapp should provide SafeAppSdk injected by Gnosis interface
+
 #### Parameters
 
 | Name | Type |
@@ -116,11 +121,6 @@ ___
 
 `Promise`<[`SignerService`](../classes/modules_signer.SignerService.md)\>
 
-**`Description`**
-
-Intended for use in Volta Gnosis web interface(https://volta.gnosis-safe.io/).
-Dapp should provide SafeAppSdk injected by Gnosis interface
-
 ___
 
 ### fromKms

diff --git a/src/modules/claims/claims.service.ts b/src/modules/claims/claims.service.ts
@@ -75,6 +75,7 @@ import {
   RevocationVerification,
   RoleEIP191JWT,
   isEIP191Jwt,
+  VerificationResult,
 } from '@energyweb/vc-verification';
 import { DidRegistry } from '../did-registry/did-registry.service';
 import { ClaimData, isClaimService } from '../did-registry/did.types';
@@ -1482,11 +1483,20 @@ export class ClaimsService {
     }
     const role = vc.credentialSubject.role.namespace;
     try {
+      let issuerVerificationResult: VerificationResult;
       if (typeof issuerDID === 'string') {
-        await this._issuerVerification.verifyIssuer(issuerDID, role);
+        issuerVerificationResult = await this._issuerVerification.verifyIssuer(
+          issuerDID,
+          role
+        );
       } else {
-        await this._issuerVerification.verifyIssuer(issuerDID.id, role);
+        issuerVerificationResult = await this._issuerVerification.verifyIssuer(
+          issuerDID.id,
+          role
+        );
       }
+      issuerVerified = issuerVerified && issuerVerificationResult.verified;
+      errors.push(issuerVerificationResult.error);
     } catch (e) {
       issuerVerified = false;
       errors.push((e as Error).message);