ci: fix browser-tests ubuntu 24.04 compat #2587
Open
+31
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
ci-fix-browser-test
branch
7 times, most recently
from
8e536e0
to
a710787
Compare
leotm
reviewed
Oct 17, 2024
Comment on lines
+32
to
+39
| - name: Install browser dependencies | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y --no-install-recommends \ | ||
| ca-certificates \ | ||
| libatomic1 libflite1 libgles2 libharfbuzz-icu0 libhyphen0 libmanette-0.2-0 libicu74 libsecret-1-0 libxslt1.1 woff2 \ | ||
| ca-certificates fonts-liberation libatk-bridge2.0-0 libatk1.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgbm1 libgcc1 libglib2.0-0 libgtk-3-0 libnspr4 libnss3 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 lsb-release wget xdg-utils \ | ||
| libvpx9 libevent-2.1-7t64 libopus0 libgstreamer-plugins-base1.0-0 libgstreamer-gl1.0-0 libgstreamer-plugins-bad1.0-0 gstreamer1.0-libav |
There was a problem hiding this comment.
are all of these extra deps required? or can any be left out to be more minimal
There was a problem hiding this comment.
They may not all be required. Most if not all were previously installed under the hood by the playwright util.
There was a problem hiding this comment.
- We should definitely install only the minimum needed
- This seems like a future maintenance burden
- Linebreaks seem inconsistent
leotm
approved these changes
Oct 17, 2024
legobeat
force-pushed
the
ci-fix-browser-test
branch
from
a710787
to
e9f230e
Compare
legobeat
force-pushed
the
ci-fix-browser-test
branch
from
e9f230e
to
c0acd95
Compare
boneskull
reviewed
Oct 25, 2024
Comment on lines
+32
to
+39
| - name: Install browser dependencies | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y --no-install-recommends \ | ||
| ca-certificates \ | ||
| libatomic1 libflite1 libgles2 libharfbuzz-icu0 libhyphen0 libmanette-0.2-0 libicu74 libsecret-1-0 libxslt1.1 woff2 \ | ||
| ca-certificates fonts-liberation libatk-bridge2.0-0 libatk1.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgbm1 libgcc1 libglib2.0-0 libgtk-3-0 libnspr4 libnss3 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 lsb-release wget xdg-utils \ | ||
| libvpx9 libevent-2.1-7t64 libopus0 libgstreamer-plugins-base1.0-0 libgstreamer-gl1.0-0 libgstreamer-plugins-bad1.0-0 gstreamer1.0-libav |
There was a problem hiding this comment.
- We should definitely install only the minimum needed
- This seems like a future maintenance burden
- Linebreaks seem inconsistent
| @@ -41,10 +53,10 @@ jobs: | |||
| run: npm ci --ignore-scripts | |||
| - name: Install Playwright Browsers | |||
| working-directory: browser-test | |||
| run: npx playwright install --with-deps | |||
| run: npm exec playwright install --with-deps | |||
There was a problem hiding this comment.
Doesn't npx do the same thing if playwright is local?
updated ^ it's to fix the recent failing Browser Tests happening in a few PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix recent failing CI browser tests
Context
Security Considerations
N/A
Scaling Considerations
N/A
Documentation Considerations
Testing Considerations
Compatibility Considerations
N/A
Upgrade Considerations
N/A