Add transport method to url #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelDavies
reviewed
Nov 27, 2019
| yield ['http']; | ||
| yield ['https']; | ||
| } | ||
|
|
There was a problem hiding this comment.
Data providers do not indeed need an array as a return, but an iterator can fit better for making them a little more readable.
NoelDavies
reviewed
Nov 27, 2019
| { | ||
| $adapter = new APC(); | ||
| $registry = new CollectorRegistry($adapter); | ||
|
|
||
| $counter = $registry->registerCounter('test', 'some_counter', 'it increases', ['type']); | ||
| $counter->incBy(6, ['blue']); | ||
|
|
||
| $pushGateway = new PushGateway('pushgateway:9091'); | ||
| $pushGateway = new PushGateway('pushgateway:9091', $transport); |
There was a problem hiding this comment.
Your code here doesn't match the constructor signature.
|
@igordrnobrega, any updates to the PR review above? |
igordrnobrega
force-pushed
the
feature/transport-method
branch
from
d3269e2
to
82218c8
Compare
|
Sorry for the, almost, 2 months delay on this, but I was really busy this end of the year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I think is a problem to have transport method hardcoded in line 81 cause it removes the flexibility of the code.
Solution
I'm adding the viability of setting it in the constructor without the need of creating or setting a new client for it and letting the class handle the client.
I also made some fix on some standards like optional parameters at the end of function declaration and type hinted
$methodindoRequestfunction