Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Login): When SCORE SSO is enabled, show SCORE login in a popup w… #566

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

geoffreykwan
Copy link
Contributor

@geoffreykwan geoffreykwan commented Sep 6, 2023

Changes

When SCORE SSO is enabled and the user is not logged in and visits a CK Board url, a window will pop up with the SCORE login page. After the user logs in, the popup window will close and the original window will be redirected to the url the user originally attempted to visit.

Note: This popup gets blocked by the browser popup blocker and the user needs to tell the browser to show the popup. I think if we have the user click a button to open the popup, it won't get blocked. See details here
https://javascript.info/popup-windows

Test

Test the SCORE login popup

  1. Make sure SCORE SSO is enabled
  2. Make sure you are logged out of SCORE and CK Board
  3. Go to a CK Board url like these below but with real urls

Project URL
http://localhost:4201/project/12345678-abcd-1234-abcd-123456789012

Board URL
http://localhost:4201/project/12345678-abcd-1234-abcd-123456789012/board/abcdefgh-1234-abcd-1234-abcdefghijkl

  1. When the SCORE login window pops up, sign in with your SCORE username and password
  2. The popup window should close and the original window should load the original url you attempted to visit

Closes #565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCORE Login Popup
1 participant