Refactor code fore blockchain network management #1691
Conversation
clangenb
added
A2-technical
clangenb
changed the title
… referring to the relaychains
clangenb
force-pushed
the
cl/network-management
branch
from
72f11da
to
cc639f3
Compare
There was a problem hiding this comment.
This was unused, we kept it as a reference, as it fetches data from subscan. By now I guess, we can be certain that we won't use subscan anymore.
| return !endpointIsTeeProxy; | ||
| } | ||
|
|
||
| @computed | ||
| bool get endpointIsTeeProxy { | ||
| return endpoint.worker != null; | ||
| return true; |
There was a problem hiding this comment.
Remove the unused endPointIsTeeProxy and default to true for endPointIsNoTee
| Future<String?> getKV(String cacheKey) { | ||
| return Future.value(); | ||
| return Future.value(storage[cacheKey] as String?); | ||
| } | ||
|
|
||
| @override | ||
| Future<void> setKV(String cacheKey, String value) { | ||
| storage[cacheKey] = value; | ||
| return Future.value(); | ||
| } |
There was a problem hiding this comment.
Had to properly overwrite some new LocalStorage methods because we use method in the real thing now.
| String id() { | ||
| return switch (this) { | ||
| encointerKusama => kusamaId, | ||
| encointerRococo => rococoId, | ||
| gesell => gesellId, | ||
| gesellDev => gesellDevId, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Before this was stored at the endpoint.info, but I think that ID fits better.
| Future<bool> removeObject(String key) { | ||
| return storage.removeKey('${customKVKey}_$key'); | ||
| } | ||
|
|
||
| Future<bool> removeKV(String key) { | ||
| return storage.removeKey(key); | ||
| } |
There was a problem hiding this comment.
There was a weird ambiguity before. We should have a look at the local storage implementation at some point: #1692
| @@ -15,7 +15,7 @@ class AccountSelectList extends StatelessWidget { | |||
| Widget build(BuildContext context) { | |||
| return ListView( | |||
| children: accounts.map((account) { | |||
| final address = AddressUtils.pubKeyHexToAddress(account.pubKey, prefix: store.settings.endpoint.ss58!); | |||
| final address = AddressUtils.pubKeyHexToAddress(account.pubKey, prefix: store.settings.currentNetwork.ss58()); | |||
There was a problem hiding this comment.
I think endpoint was a misnomer since ever. I changed it to currentNetwork.
I did this as a preparation for task for #1603 in order to simplify management of multiple endpoints per network.
Changes
!/?operators in the code base.Testing: