Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get node binary via @nodejs//:node #1151

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Get node binary via @nodejs//:node #1151

wants to merge 2 commits into from

Commits on Dec 17, 2022

  1. Get node binary via @nodejs//:node 

    I had a colleague using an arm64 mac whose builds were failing because `platform.machine()` was returning amd64 for some reason (my guess is the python toolchain was running under Rosetta). Then emscripten_config looked for the node binary in a nonexistent directory -- nodejs_darwin_amd64 rather than nodejs_darwin_arm64.

This switches to a public rules_nodejs API for obtaining the binary, so should always work.
    @jfirebaugh
    jfirebaugh committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    ea458fb View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Speculative fix for Windows CI

    @jfirebaugh
    jfirebaugh committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    ba2e7fa View commit details
    Browse the repository at this point in the history