Allow avxintrin.h to be used by C compiler #22850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An internal union defined to implement 256-bit AVX support added in PR emscripten-core#22430 is missing `union` keywords at declarations so causes errors when used with the C compiler. Add the `union` keyword to the declarations of the `m256_data` union in avxintrin.h. Also adds `__` prefix to make type `__m256_data` to avoid further polluting global namespace.
sbc100
approved these changes
Nov 5, 2024
It looks like the |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 5, 2024
Include `compat` headers. See emscripten-core#22850
|
I just uploaded #22854. Once that land you should be able to remove the exceptions for these headers from |
sbc100
added a commit
that referenced
this pull request
Nov 5, 2024
Include `compat` headers. See #22850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An internal union defined to implement 256-bit AVX support added in PR #22430 is missing
unionkeywords at declarations so causes errors when used with the C compiler.Add the
unionkeyword to the declarations of them256_dataunion in avxintrin.h. Also adds__prefix to make type__m256_datato avoid further polluting global namespace.