Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #20471 #22838

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix #20471 #22838

wants to merge 1 commit into from

Conversation

lorsanta
Copy link

@lorsanta lorsanta commented Nov 3, 2024

Added a tip to explain how to permanently add environment variables

@kripken
Copy link
Member

kripken commented Nov 14, 2024

Thanks @lorsanta for the PR. Personally, I am not sure this level of detail is worth getting into, however: most users probably know how to use their shell to do this, or know how to search to find out how (I am in the second camp... I always need to look it up, but it just takes a minute). Curious what other people think.

@kripken
Copy link
Member

kripken commented Nov 14, 2024

I'd be more comfortable with a general link to a place that explains how to do it on various shells and OSes, for example. Though I'm not sure if there is one?

@@ -52,6 +52,8 @@ GitHub and set them as :term:`active <Active Tool/SDK>`:
# Activate PATH and other environment variables in the current terminal
source ./emsdk_env.sh

.. tip:: If you want to avoid to execute ``source /path/to/emsdk/emsdk_env.sh`` everytime you open a new terminal, run ``echo source /path/to/emsdk/emsdk_env.sh >> ~/.bashrc``.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/execute/executing/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

If you want to avoid executing `source ./emsdk_env.sh` every time you open a new terminal you can follow the intstructions given by the `emsdk activate` command above to add this command to your startup scripts.

This avoids mentioning the bash stuff specifically, since we support multiple different shells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants