Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix sometimes will update emqx config #992

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix: fix sometimes will update emqx config #992

merged 1 commit into from
Jan 8, 2024

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Jan 8, 2024

fix sometimes will access EMQX api, event emqx config not change.

fix configmap no have owner reference

fix sometimes will access EMQX api, event emqx config not change.

fix configmap no have owner reference

Signed-off-by: Rory Z <[email protected]>
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (d6908b6) 77.21% compared to head (d4eb415) 77.01%.
Report is 1 commits behind head on main.

Files Patch % Lines
controllers/apps/v2beta1/sync_emqx_config.go 70.58% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
- Coverage   77.21%   77.01%   -0.20%     
==========================================
  Files          67       67              
  Lines        6060     6077      +17     
==========================================
+ Hits         4679     4680       +1     
- Misses       1160     1175      +15     
- Partials      221      222       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit 7e9255f into emqx:main Jan 8, 2024
32 of 34 checks passed
@Rory-Z Rory-Z deleted the fix/fix-config branch January 8, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant