Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check EMQX condition before revert sts/rs #986

Merged
merged 1 commit into from
Jan 7, 2024
Merged

fix: check EMQX condition before revert sts/rs #986

merged 1 commit into from
Jan 7, 2024

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Jan 7, 2024

No description provided.

@Rory-Z Rory-Z requested a review from a team as a code owner January 7, 2024 11:42
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (32cb361) 77.04% compared to head (fa055b6) 77.24%.
Report is 1 commits behind head on main.

Files Patch % Lines
controllers/apps/v2beta1/add_emqx_core.go 55.55% 3 Missing and 1 partial ⚠️
controllers/apps/v2beta1/add_emqx_repl.go 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
+ Coverage   77.04%   77.24%   +0.19%     
==========================================
  Files          67       67              
  Lines        6056     6060       +4     
==========================================
+ Hits         4666     4681      +15     
+ Misses       1168     1157      -11     
  Partials      222      222              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit d6908b6 into emqx:main Jan 7, 2024
29 of 34 checks passed
@Rory-Z Rory-Z deleted the check-status branch January 7, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant