Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change svc template to pointer #925

Merged
merged 1 commit into from
Aug 17, 2023
Merged

chore: change svc template to pointer #925

merged 1 commit into from
Aug 17, 2023

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Aug 16, 2023

No description provided.

@Rory-Z Rory-Z requested a review from a team as a code owner August 16, 2023 15:33
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% 🎉

Comparison is base (e7baafd) 77.16% compared to head (c55d3b1) 77.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   77.16%   77.23%   +0.07%     
==========================================
  Files          67       67              
  Lines        6038     6044       +6     
==========================================
+ Hits         4659     4668       +9     
  Misses       1150     1150              
+ Partials      229      226       -3     
Files Changed Coverage Δ
apis/apps/v2beta1/emqx_types.go 100.00% <ø> (ø)
controllers/apps/v2beta1/add_svc.go 75.71% <100.00%> (+1.08%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit ef84e86 into emqx:main Aug 17, 2023
37 checks passed
@Rory-Z Rory-Z deleted the chore/delete-default-webhook branch August 17, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant