Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2beta1): when pod have DeletionTimestamp, don't scale down #895

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix(v2beta1): when pod have DeletionTimestamp, don't scale down #895

merged 1 commit into from
Jul 31, 2023

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Jul 31, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.63% ⚠️

Comparison is base (9beb50a) 78.36% compared to head (981bbbb) 77.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
- Coverage   78.36%   77.73%   -0.63%     
==========================================
  Files          67       67              
  Lines        5915     5924       +9     
==========================================
- Hits         4635     4605      -30     
- Misses       1076     1107      +31     
- Partials      204      212       +8     
Files Changed Coverage Δ
controllers/apps/v2beta1/sync_pods.go 59.50% <75.00%> (-10.66%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit b8fa587 into emqx:main Jul 31, 2023
35 of 37 checks passed
@Rory-Z Rory-Z deleted the fix/fix-sync-pod branch July 31, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant