Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2beta1): remove finalizer when rebalance completed or fialed #893

Merged
merged 1 commit into from
Jul 30, 2023
Merged

chore(v2beta1): remove finalizer when rebalance completed or fialed #893

merged 1 commit into from
Jul 30, 2023

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Jul 30, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3b19400) 77.98% compared to head (9966883) 77.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #893   +/-   ##
=======================================
  Coverage   77.98%   77.98%           
=======================================
  Files          67       67           
  Lines        5913     5915    +2     
=======================================
+ Hits         4611     4613    +2     
  Misses       1093     1093           
  Partials      209      209           
Files Changed Coverage Δ
controllers/apps/v2beta1/rebalance_controller.go 74.65% <100.00%> (+0.17%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit 39676a8 into emqx:main Jul 30, 2023
37 checks passed
@Rory-Z Rory-Z deleted the chore/remote-finilize branch July 30, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant