Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2alpha2): don't format hocon in default webhook #871

Merged
merged 1 commit into from
Jul 20, 2023
Merged

chore(v2alpha2): don't format hocon in default webhook #871

merged 1 commit into from
Jul 20, 2023

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Jul 20, 2023

Avoid conflicting with validate create webhook.

Avoid conflicting with validate create webhook.
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +25.80 🎉

Comparison is base (7890524) 52.95% compared to head (07ee21a) 78.76%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #871       +/-   ##
===========================================
+ Coverage   52.95%   78.76%   +25.80%     
===========================================
  Files          67       67               
  Lines        5578     5580        +2     
===========================================
+ Hits         2954     4395     +1441     
+ Misses       2550     1008     -1542     
- Partials       74      177      +103     
Impacted Files Coverage Δ
apis/apps/v2alpha2/emqx_webhook.go 94.85% <100.00%> (-0.15%) ⬇️

... and 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Rory-Z Rory-Z merged commit 23309df into emqx:main Jul 20, 2023
36 checks passed
@Rory-Z Rory-Z deleted the chore/dont-format-hocon branch July 20, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant