Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update controller-runtime version #1032

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Apr 8, 2024

No description provided.

@Rory-Z Rory-Z force-pushed the chore/update-tools-version branch 17 times, most recently from b4cb1eb to 69fa0c4 Compare April 9, 2024 03:19
@Rory-Z Rory-Z force-pushed the chore/update-tools-version branch from 69fa0c4 to 4251094 Compare April 9, 2024 03:41
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 62.16216% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 76.72%. Comparing base (a761bf3) to head (4251094).

Files Patch % Lines
apis/apps/v1beta4/emqxplugin_webhook.go 0.00% 7 Missing ⚠️
apis/apps/v1beta4/emqxbroker_webhook.go 75.00% 2 Missing ⚠️
apis/apps/v1beta4/emqxenterprise_webhook.go 75.00% 2 Missing ⚠️
apis/apps/v2beta1/rebalance_webhook.go 77.77% 2 Missing ⚠️
controllers/apps/v2beta1/add_emqx_repl.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   76.78%   76.72%   -0.07%     
==========================================
  Files          68       68              
  Lines        6173     6173              
==========================================
- Hits         4740     4736       -4     
- Misses       1202     1206       +4     
  Partials      231      231              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z changed the title chore: update golang x tools version chore: update controller-runtime version Apr 9, 2024
@Rory-Z Rory-Z merged commit e010fed into emqx:main Apr 9, 2024
33 of 35 checks passed
@Rory-Z Rory-Z deleted the chore/update-tools-version branch April 9, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant