iOS: Support putting UI next to the dynamic island #5211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winit::Window::inner_size returns size of safe area on iOS. use winit::Window::outer_size on iOS
|
Preview available at https://egui-pr-preview.github.io/pr/5211-iOS-black-bar |
lucasmerlin
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
I think this makes sense. Now we will still have to manually work around the safe area (until this is done: rust-windowing/winit#3890) but at least egui will render on the whole screen
lucasmerlin
added
bug
|
@lucasmerlin I updated my safe area implementation so it is actually usable. it could be merged and the get_safe_area_insets could be replaced while upgrading winit in the future |
|
@emilk is this alright? |
emilk
approved these changes
Oct 23, 2024
Co-authored-by: Emil Ernerfeldt <[email protected]>
emilk
approved these changes
Oct 23, 2024
emilk
changed the title
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
winit::Window::inner_size returns size of safe area on iOS. use winit::Window::outer_size on iOS The dimensions of outer_size include the title bar and borders, but as far as I know there is no way to actually display the title bar or borders on iOS so it should be fine. <!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to test and add commits to your PR. * Remember to run `cargo fmt` and `cargo clippy`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> * Closes emilk#3547 * [X] I have followed the instructions in the PR template --------- Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winit::Window::inner_size returns size of safe area on iOS. use winit::Window::outer_size on iOS
The dimensions of outer_size include the title bar and borders, but as far as I know there is no way to actually display the title bar or borders on iOS so it should be fine.