Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly include headers and libraries #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/rapidcheck/Check.hpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include <iostream>
#include <string>

#include "rapidcheck/detail/Configuration.h"
#include "rapidcheck/detail/Results.h"
Expand Down
1 change: 1 addition & 0 deletions include/rapidcheck/Classify.hpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include <string>
#include <initializer_list>

namespace rc {
namespace detail {
Expand Down
1 change: 1 addition & 0 deletions include/rapidcheck/Gen.hpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include <cassert>
#include <exception>

#include "rapidcheck/detail/Any.h"
#include "rapidcheck/detail/ImplicitParam.h"
Expand Down
1 change: 1 addition & 0 deletions include/rapidcheck/GenerationFailure.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include <stdexcept>
#include <string>

namespace rc {

Expand Down
4 changes: 4 additions & 0 deletions include/rapidcheck/Log.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
#pragma once

#include <cstdlib>
#include <ostream>
#include <string>

namespace rc {
namespace detail {

Expand Down
2 changes: 2 additions & 0 deletions include/rapidcheck/Maybe.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#pragma once

#include <utility>

#include "rapidcheck/Show.h"

namespace rc {
Expand Down
3 changes: 2 additions & 1 deletion include/rapidcheck/Random.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
#pragma once

#include <cstdint>
#include <array>
#include <cstdint>
#include <cstdlib>
#include <limits>

namespace rc {
Expand Down
2 changes: 2 additions & 0 deletions include/rapidcheck/Random.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#include "rapidcheck/detail/Serialization.h"

#include <tuple>

namespace rc {

template <typename Iterator>
Expand Down
5 changes: 4 additions & 1 deletion include/rapidcheck/Show.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,19 @@
#include <map>
#include <vector>
#include <deque>
#include <forward_list>
#include <list>
#include <set>
#include <unordered_set>
#include <unordered_map>
#include <memory>
#include <cstdlib>
#include <cstdint>
#include <type_traits>
#include <array>
#include <sstream>
#include <tuple>
#include <ostream>
#include <forward_list>

#include "rapidcheck/detail/Traits.h"

Expand Down
3 changes: 3 additions & 0 deletions include/rapidcheck/detail/AlignedUnion.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#pragma once

#include <cstdlib>
#include <type_traits>

namespace rc {
namespace detail {

Expand Down
2 changes: 2 additions & 0 deletions include/rapidcheck/detail/Any.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#pragma once


#include <memory>
#include <ostream>
#include <string>

namespace rc {
Expand Down
1 change: 1 addition & 0 deletions include/rapidcheck/detail/Any.hpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include <cassert>
#include <typeinfo>

#include "rapidcheck/Traits.h"
#include "rapidcheck/Show.h"
Expand Down
5 changes: 4 additions & 1 deletion include/rapidcheck/detail/ApplyTuple.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
#pragma once

#include "rapidcheck/detail/IntSequence.h"
#include <tuple>
#include <utility>

#include "rapidcheck/Traits.h"

namespace rc {
namespace detail {
Expand Down
1 change: 1 addition & 0 deletions include/rapidcheck/detail/BitStream.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include <cstdint>
#include <type_traits>

namespace rc {
namespace detail {
Expand Down
2 changes: 2 additions & 0 deletions include/rapidcheck/detail/BitStream.hpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
#pragma once

#include <algorithm>
#include <limits>

#include "rapidcheck/detail/Utility.h"
#include "rapidcheck/Gen.h"

namespace rc {
namespace detail {
Expand Down
4 changes: 4 additions & 0 deletions include/rapidcheck/detail/ExecFixture.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
#pragma once


#include <utility>
#include <rapidcheck/detail/FunctionTraits.h>

namespace rc {
namespace detail {

Expand Down
1 change: 1 addition & 0 deletions include/rapidcheck/detail/FrequencyMap.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include <vector>
#include <cstdlib>

namespace rc {
namespace detail {
Expand Down
4 changes: 4 additions & 0 deletions include/rapidcheck/detail/FunctionTraits.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
#pragma once

#include <type_traits>

#include "TypeList.h"
#include "rapidcheck/Traits.h"


namespace rc {
namespace detail {
Expand Down
3 changes: 3 additions & 0 deletions include/rapidcheck/detail/IntSequence.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#pragma once

#include <cstdlib>
#include <type_traits>

namespace rc {
namespace detail {

Expand Down
2 changes: 2 additions & 0 deletions include/rapidcheck/detail/Serialization.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#pragma once

#include <cstdint>
#include <cstdlib>
#include <stdexcept>
#include <string>
#include <unordered_map>
Expand Down
4 changes: 4 additions & 0 deletions include/rapidcheck/detail/Serialization.hpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
#include "Serialization.h"

#include <algorithm>
#include <limits>
#include <type_traits>
#include <utility>


namespace rc {
namespace detail {
Expand Down
3 changes: 3 additions & 0 deletions include/rapidcheck/detail/ShowType.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#pragma once

#include <iostream>
#include <string>

namespace rc {
namespace detail {

Expand Down
3 changes: 3 additions & 0 deletions include/rapidcheck/detail/TypeList.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#pragma once

#include <tuple>
#include <type_traits>

namespace rc {
namespace detail {

Expand Down
5 changes: 4 additions & 1 deletion include/rapidcheck/detail/Utility.h
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
#pragma once

#include <cstdlib>
#include <limits>
#include <string>
#include <tuple>
#include <limits>
#include <type_traits>
#include <utility>

namespace rc {
namespace detail {
Expand Down
2 changes: 2 additions & 0 deletions include/rapidcheck/detail/Variant.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#pragma once

#include <utility>

namespace rc {
namespace detail {

Expand Down
2 changes: 2 additions & 0 deletions include/rapidcheck/fn/Common.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#pragma once

#include "rapidcheck/Traits.h"

namespace rc {
namespace fn {

Expand Down
5 changes: 5 additions & 0 deletions include/rapidcheck/fn/Common.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#pragma once

#include <type_traits>
#include <utility>

#include "rapidcheck/Traits.h"

namespace rc {
namespace fn {

Expand Down
2 changes: 2 additions & 0 deletions include/rapidcheck/gen/Build.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#pragma once

#include "rapidcheck/Gen.h"

namespace rc {
namespace gen {
namespace detail {
Expand Down
2 changes: 2 additions & 0 deletions include/rapidcheck/gen/Chrono.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#pragma once

#include "rapidcheck/gen/Arbitrary.h"

namespace rc {
namespace gen {
namespace detail {
Expand Down
1 change: 1 addition & 0 deletions include/rapidcheck/gen/Exec.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include "rapidcheck/detail/FunctionTraits.h"
#include "rapidcheck/Gen.h"

namespace rc {
namespace gen {
Expand Down
2 changes: 2 additions & 0 deletions include/rapidcheck/gen/Select.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#pragma once

#include <initializer_list>

namespace rc {
namespace gen {

Expand Down
2 changes: 2 additions & 0 deletions include/rapidcheck/gen/Select.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#pragma once

#include <initializer_list>

#include "rapidcheck/detail/FrequencyMap.h"
#include "rapidcheck/gen/detail/ScaleInteger.h"

Expand Down
1 change: 1 addition & 0 deletions include/rapidcheck/gen/detail/ExecRaw.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#pragma once

#include "rapidcheck/Gen.h"
#include "rapidcheck/detail/FunctionTraits.h"
#include "rapidcheck/gen/detail/Recipe.h"

Expand Down
1 change: 1 addition & 0 deletions include/rapidcheck/gen/detail/ShrinkValueIterator.hpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#pragma once
#include <cstddef>

namespace rc {
namespace gen {
Expand Down
3 changes: 2 additions & 1 deletion include/rapidcheck/seq/Create.hpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include "rapidcheck/seq/Transform.h"
#include <cstdlib>

namespace rc {
namespace seq {
Expand Down Expand Up @@ -189,7 +190,7 @@ Seq<std::pair<std::size_t, std::size_t>> subranges(std::size_t start,
return seq::map(
seq::range<std::size_t>(start, end - rangeSize + 1),
[=](std::size_t rangeStart) {
return std::make_pair(rangeStart,
return std::pair<std::size_t, std::size_t>(rangeStart,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect formatting.

rangeStart + rangeSize);
});
});
Expand Down
2 changes: 2 additions & 0 deletions src/GenerationFailure.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#include "rapidcheck/GenerationFailure.h"


#include <string>
#include <utility>

namespace rc {

Expand Down
2 changes: 2 additions & 0 deletions src/detail/Base64.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#pragma once

#include <cstdint>
#include <cstdlib>
#include <string>
#include <vector>

Expand Down
3 changes: 2 additions & 1 deletion src/detail/FrequencyMap.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#include "rapidcheck/detail/FrequencyMap.h"

#include <algorithm>
#include <iterator>

namespace rc {
namespace detail {
Expand All @@ -15,7 +16,7 @@ FrequencyMap::FrequencyMap(const std::vector<std::size_t> &frequencies)
}

std::size_t FrequencyMap::lookup(std::size_t x) const {
return std::upper_bound(begin(m_table), end(m_table), x) - begin(m_table);
return std::upper_bound(std::begin(m_table), std::end(m_table), x) - std::begin(m_table);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not relying on ADL anyway, I'd prefer .begin() and .end().

}

std::size_t FrequencyMap::sum() const { return m_sum; }
Expand Down
1 change: 1 addition & 0 deletions src/seq/Create.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include <rapidcheck/seq/Create.h>