-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vite compat styles resolver #1854
base: main
Are you sure you want to change the base?
Conversation
0d48436
to
a4e1d53
Compare
b768d3f
to
2976f0e
Compare
Discussed this together in office hours. This is implementing a feature that might be useful for people who are ready to completely opt out of the classic style pipeline. But it doesn't mix well with that pipeline. Today, sass from v1 addons does work in the classic An |
I'm marking this as "waiting for contributor" since @ef4 laid out a way forward and this PR would need extra work before we could consider merging 👍 |
There are.scss or .less files in some v1 addons, which currently can only be consumed because they are copied to rewritten-app/assets.
But i could now do something like this in vite:
And have app.js import app.scss