Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non supported bugfix and security patch until dates #1083

Conversation

geneukum
Copy link
Contributor

Per this message in the ember-js discord, let's add a couple of new columns (Bugfixes until and Security patches until) to the no longer maintained LTS table on the releases/lts route.

While glossing over this, I think that I caught a few instances where we were showing the incorrect minor version / date for a few LTS versions as well, but definitely worth double checking them.

Right now, the no longer maintained table suggests that the last release
for the 3.28 LTS was 3.28.11. This is incorrect, as 3.28.12 was released
in May of 2023. Let's update this table to reflect that.
Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit da562da
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/65ca9a26201eb90008905c4a
😎 Deploy Preview https://deploy-preview-1083--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@geneukum geneukum force-pushed the add-non-supported-bugfix-and-security-patch-until-dates branch from 7e5693c to ced27d6 Compare February 11, 2024 20:22
Right now, the no longer maintained table suggests that the last release
for the 3.24 LTS was 3.24.6. This is incorrect, as 3.24.7 was released
in November of 2022. Let's update this table to reflect that.
Right now, the no longer maintained table suggests that the last release
for the 3.20 LTS was 3.20.3. This is incorrect, as 3.20.6 was released
in November of 2020. Let's update this table to reflect that.
It would be useful to show rough "Bugfix until" and "Security patches
until" dates for the no longer maintained LTS versions (similar to how
we do for the currently maintained LTS versions).

Let's make it so!
@geneukum geneukum force-pushed the add-non-supported-bugfix-and-security-patch-until-dates branch from ced27d6 to 8281551 Compare February 12, 2024 19:56
kategengler
kategengler previously approved these changes Feb 12, 2024
@kategengler kategengler dismissed their stale review February 12, 2024 21:26

Need to fix some thing

Copy link
Contributor

@kategengler kategengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the column from the last minor date to the LTS promotion date based on the blog post dates

app/templates/releases/lts.hbs Outdated Show resolved Hide resolved
app/templates/releases/lts.hbs Outdated Show resolved Hide resolved
app/templates/releases/lts.hbs Outdated Show resolved Hide resolved
app/templates/releases/lts.hbs Outdated Show resolved Hide resolved
app/templates/releases/lts.hbs Outdated Show resolved Hide resolved
app/templates/releases/lts.hbs Outdated Show resolved Hide resolved
app/templates/releases/lts.hbs Outdated Show resolved Hide resolved
app/templates/releases/lts.hbs Outdated Show resolved Hide resolved
app/templates/releases/lts.hbs Outdated Show resolved Hide resolved
app/templates/releases/lts.hbs Outdated Show resolved Hide resolved
@kategengler
Copy link
Contributor

Thank you for this; if you're up for another PR after this, I think removing that latest minor version column could be useful. It seems like something that is irksome to keep up to date. We could link to the npm versions page instead https://www.npmjs.com/package/ember-source?activeTab=versions

@geneukum
Copy link
Contributor Author

Thank you for this; if you're up for another PR after this, I think removing that latest minor version column could be useful. It seems like something that is irksome to keep up to date. We could link to the npm versions page instead https://www.npmjs.com/package/ember-source?activeTab=versions

Sure thing! Good idea to switch the last minor date to the promotion date. I think that it was a little funky because some LTS versions received patches after the cutoffs if I remember correctly.

I'll make a separate PR to drop that column and add some text to link to the versions page on NPM instead.

@kategengler
Copy link
Contributor

@ember-learn/learning-core-team who can review Percy?

@MinThaMie MinThaMie merged commit 02d09b9 into ember-learn:main Feb 14, 2024
6 checks passed
@geneukum geneukum deleted the add-non-supported-bugfix-and-security-patch-until-dates branch February 14, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants