Add test apps (addon, app) x (js, ts) #237
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
smoke-tests
branch
from
a53882a
to
a1c625a
Compare
…on these packages
…f date, so update that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: #236
broke stuff in a separate repo (private/internal), so here, I add tests for the 4 scenarios than ember-template-imports supports
This PR is immensely boilerplate-heavy, so you'll want to review by commit.
I don't know why I can't add to CI right now, but locally, I've confirm these pass/fail states:
which means that something goofy is going on in repo where #236 is causing issues 🤔 HMMMMM