Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] ember-3x-codemods for version 3.1 #22

Merged
merged 6 commits into from
Sep 28, 2019
Merged

[FEAT] ember-3x-codemods for version 3.1 #22

merged 6 commits into from
Sep 28, 2019

Conversation

rajasegar
Copy link
Contributor

@rajasegar rajasegar commented Sep 22, 2019 •
edited
Loading

#21
Use notifyPropertyChange instead of propertyWillChange and propertyDidChange
Deprecations Added in 3.1

Input

Ember.propertyWillChange(object, 'someProperty');
doStuff(object);
Ember.propertyDidChange(object, 'someProperty');

object.propertyWillChange('someProperty');
doStuff(object);
object.propertyDidChange('someProperty');

Output

doStuff(object);
Ember.notifyPropertyChange(object, 'someProperty');

doStuff(object);
object.notifyPropertyChange('someProperty');

kellyselden
kellyselden requested changes Sep 23, 2019
View reviewed changes
manifest.json Outdated Show resolved Hide resolved
@kellyselden kellyselden mentioned this pull request Sep 23, 2019
Merged
@rajasegar
[CHORE] Review comments - New section for ember-3x-codemods
d5ba513
@rajasegar
[CHORE] Rename block ember-3x-codemods
d29cc15 
Renaming the block to specific codemod name
instead of generic ember-3x-codemods so that
we won't have any name clashes in the future.
kellyselden
kellyselden reviewed Sep 25, 2019
View reviewed changes
manifest.json Outdated Show resolved Hide resolved
kellyselden
kellyselden reviewed Sep 25, 2019
View reviewed changes
manifest.json Outdated Show resolved Hide resolved
@kellyselden kellyselden merged commit 911b8c5 into ember-cli:v3 Sep 28, 2019
@kellyselden
Copy link
Member

All good to go. Thanks again!

@rajasegar
Copy link
Contributor Author

Thanks @kellyselden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellyselden kellyselden kellyselden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajasegar @kellyselden