fix: Fix sourcemap file lookup

[mydea]

We ran into this here: getsentry/sentry-javascript#9168, where the build failed when source maps & terser were enabled.

The root cause is that the used dependency: https://github.com/lydell/source-map-url is very old, and the regex it uses is not bullet proof. So this code (that some dependency generated):

function createURL(base64, sourcemapArg, enableUnicodeArg) {
    var sourcemap = sourcemapArg === undefined ? null : sourcemapArg;
    var enableUnicode = enableUnicodeArg === undefined ? false : enableUnicodeArg;
    var source = decodeBase64(base64, enableUnicode);
    var start = source.indexOf('\n', 10) + 1;
    var body = source.substring(start) + (sourcemap ? '//# sourceMappingURL=' + sourcemap : '');
    var blob = new Blob([body], { type: 'application/javascript' });
    return URL.createObjectURL(blob);
}

Was incorrectly matched by the regex, but return an '' url. Which then in turn messed up this addon, because while fs.existsSync(sourceMapPath) passed, it actually pointed to a directory, not a path (because of let sourceMapPath = path.join(inFileDirname, urls[i]);, where the url is '').

This PR does two thigns:

1. Update to use the regex from https://github.com/thlorenz/convert-source-map, which is more up to date and also what source-map-url recommends
2. Try-catch reading the file anyhow, so even if something goes wrong there, no need to blow up

[herzzanu]

@Turbo87 @rwjblue sorry for the ping, not sure who's the most actively maintaining this repo. Would be great to get this or #314 merged

[Turbo87]

/cc @ember-cli/ember-cli ⬆️

[NullVoxPopuli]

any way we can use convert-source-map directly instead of needing teh lib/source-map-url.js file?

[mydea]

It seems to work a bit differently, and I didn't find a good method it exposed (?) to just get all source map URLs in a file - there is a method to just get the last one, and a method to remove all of them in the file, both of which are not suited to what we need here 😓

[NullVoxPopuli]

thanks a ton for the additional tests!!!!

[NullVoxPopuli]

now that 0.4.1 is removed, what's still bringing this in to the dep graph? 🤔

[mydea]

it is some deep dependency (source-map-resolve < snapdragon < nanomatch ....) 😬

[NullVoxPopuli]

thanks a bunch for working on this! 🎉

[NullVoxPopuli]

Thanks a ton for working on this!!!

[mydea]

Thanks a ton for working on this!!!

🙏 it would be great if we could merge & release this as a patch level release in order for all packages depending on this getting this fix "for free"!