Don't restrict org outline path length #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to address two issues by removing restriction of outline path length to window width in
helm-org-agenda-files-headings
:helm-org-agenda-files-headings
get truncated to the width of the previously active window, not the helm-window.Reasoning for 1.:
The leaf node is likely the most interesting part of the candidate, it shouldn't be cut off. In comparable scenarios like
helm-find-files
there is also no truncation.Not truncating candidates will use the full helm window width, and users can use horizontal scrolling or wrapping (via
helm-org-truncate-lines
orhelm-toggle-truncate-line
) to inspect the full path if required.Repro steps for 2.:
helm-org-agenda-files-headings
The reason seems to be that
helm-window
returnsnil
whenhelm-org--get-candidates-in-file
is called, so thewindow-width
call returns the width of the current window instead.Behaviour seems similar to the now inaccessible issue 1294 in helm, if that is of any relevance. Still available currently via google webcache:
https://webcache.googleusercontent.com/search?q=cache:BPTMko9B-8kJ:https://github.com/emacs-helm/helm/issues/1294
GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2020-09-19
Org version 9.4 from package org-plus-contrib version 20201005
helm
versions tested with:3.6.2
helm-core
versions tested with:20200905.1311