Extract a ViewModelHelper that will be useful with static view models #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The diff has huge blocks of + and -, which is very difficult to review on my phone. Is it possible to extract smaller pieces in separate PRs? |
marner2
force-pushed
the
feature/extract_view_model_helper
branch
from
f6befc9
to
17ae441
Compare
|
@TysonMN can you view the diffs one commit at a time? A lot of these changes don't make much sense on their own. |
|
Also the majority of the diff issue happens when I split the class in two at the end, and I don't think I can help that because the diff view doesn't track code reordering (which must be done at that time and can't be reduced any more that I can see). |
This comment was marked as outdated.
This comment was marked as outdated.
marner2
force-pushed
the
feature/extract_view_model_helper
branch
from
e6e355a
to
5743879
Compare
marner2
force-pushed
the
feature/extract_view_model_helper
branch
from
5743879
to
1e1cfea
Compare
TysonMN
reviewed
Oct 14, 2022
TysonMN
requested changes
Oct 15, 2022
marner2
force-pushed
the
feature/extract_view_model_helper
branch
from
1e1cfea
to
77fdba1
Compare
marner2
force-pushed
the
feature/extract_view_model_helper
branch
from
77fdba1
to
b224d3e
Compare
TysonMN
force-pushed
the
feature/extract_view_model_helper
branch
from
b224d3e
to
bd7fd0b
Compare
marner2
force-pushed
the
feature/extract_view_model_helper
branch
from
bd7fd0b
to
bab8b19
Compare
TysonMN
force-pushed
the
feature/extract_view_model_helper
branch
from
bab8b19
to
73456a3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
marner2
force-pushed
the
feature/extract_view_model_helper
branch
from
73456a3
to
e20870b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
TysonMN
force-pushed
the
feature/extract_view_model_helper
branch
from
e20870b
to
1e41dff
Compare
marner2
force-pushed
the
feature/extract_view_model_helper
branch
from
1e41dff
to
52a8dab
Compare
TysonMN
force-pushed
the
feature/extract_view_model_helper
branch
from
52a8dab
to
ac93865
Compare
Merged
TysonMN
reviewed
Nov 11, 2022
| @@ -34,6 +34,75 @@ module internal IViewModel = | |||
| let currentModel (vm: #IViewModel<'model, 'msg>) = vm.CurrentModel | |||
| let updateModel (vm: #IViewModel<'model, 'msg>, m: 'model) = vm.UpdateModel(m) | |||
|
|
|||
| type internal ViewModelHelper<'model, 'msg> = | |||
There was a problem hiding this comment.
Would a better name be ViewModelState?
|
|
||
| let mutable helper = | ||
| ViewModelHelper.create | ||
| (fun () -> this) |
There was a problem hiding this comment.
I think it was originally to avoid using references to this in the initialization section, but I'm not sure anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should rebase easily after #535This should be a behavior-preserving transform that extracts some behavior from
DynamicViewModelinto aViewModelHelperwhich can then be shared with a futureViewModelBaseimplemented in #522