-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support empty string for safe access operator #1176
Open
w-lfchen
wants to merge
7
commits into
elkowar:master
Choose a base branch
from
w-lfchen:feat/safe_access
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
w-lfchen
force-pushed
the
feat/safe_access
branch
from
August 28, 2024 18:18
b3ba4ea
to
283087e
Compare
2 tasks
w-lfchen
force-pushed
the
feat/safe_access
branch
from
August 31, 2024 06:44
dc6b84f
to
dc9b3de
Compare
w-lfchen
force-pushed
the
feat/safe_access
branch
from
September 3, 2024 12:53
dc9b3de
to
4f6cb43
Compare
w-lfchen
force-pushed
the
feat/safe_access
branch
from
September 7, 2024 12:06
4f6cb43
to
13e9976
Compare
w-lfchen
commented
Sep 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dropped the dependency updates, that should be done in a separate pr alongside updating to rust 1.81
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
'""'
. #629resolves it's changes requested here
Additional Notes
This contains the breaking change of no longer supporting safe access for JSON strings, should that be mentioned in the change log or maybe even reverted?
Checklist
docs/content/main
directory has been adjusted to reflect my changes.cargo fmt
to automatically format all code before committing