New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gemma attention head size #364

Merged

jonatanklosko merged 1 commit into elixir-nx:main from cmeon:gemma-attention-fix

Mar 21, 2024

Contributor

cmeon commented Mar 20, 2024

This fix adds attention_head_size which is different for Gemma, equal to 256.

Without this, during module building, the runtime would ignore the mismatched shapes and result in unintelligible results.

00:15:21.191 [debug] the following parameters were ignored, because of non-matching shape:

  * decoder.blocks.24.self_attention.value.kernel (expected {3072, 3072}, got: {3072, 4096})
  * decoder.blocks.18.self_attention.value.kernel (expected {3072, 3072}, got: {3072, 4096})
  * decoder.blocks.18.self_attention.output.kernel (expected {3072, 3072}, got: {4096, 3072})
  ...

See:

gemma 7B model configuration google-deepmind/gemma#4


          Add Gemma attention head size

7e06683

jonatanklosko approved these changes

View reviewed changes

Member

jonatanklosko left a comment

Good catch, thanks!

jonatanklosko merged commit 2fbe380 into elixir-nx:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet