review

pyproject.toml

@@ -4,6 +4,7 @@ requires = ["poetry-core"]
 
 [tool.bandit]
 skips = [
+  "B101", # Use of assert detected.
   "B321", # FTP-related functions are being called.
   "B402", # A FTP-related module is being imported.
   "B108"  # Insecure usage of temp file/directory, false positive.

tesk/api/ga4gh/tes/controllers.py

@@ -1,7 +1,7 @@
 """Controllers for GA4GH TES API endpoints."""
 
 import logging
-from typing import Any
+from typing import Mapping
 
 from foca.utils.logging import log_traffic  # type: ignore
 from pydantic import ValidationError
@@ -36,7 +36,7 @@ def CreateTask(**kwargs) -> dict:
     Args:
         **kwargs: Arbitrary keyword arguments.
     """
-    request_body: Any = kwargs.get("body")
+    request_body: Mapping = kwargs.get("body", {})
     try:
         tes_task = TesTask(**request_body)
     except ValidationError as e:

tesk/utils.py

@@ -31,31 +31,6 @@
 from tesk.exceptions import ConfigInvalidError, ConfigNotFoundError
 from tesk.k8s.constants import tesk_k8s_constants
 
-from foca import Foca
-from kubernetes.client.models import (
-    V1Container,
-    V1DownwardAPIVolumeFile,
-    V1DownwardAPIVolumeSource,
-    V1EnvVar,
-    V1EnvVarSource,
-    V1Job,
-    V1JobSpec,
-    V1ObjectFieldSelector,
-    V1ObjectMeta,
-    V1PodSpec,
-    V1PodTemplateSpec,
-    V1SecretKeySelector,
-    V1Volume,
-    V1VolumeMount,
-)
-
-from tesk.custom_config import (
-    CustomConfig,
-    Taskmaster,
-)
-from tesk.exceptions import ConfigInvalidError
-from tesk.k8s.constants import tesk_k8s_constants
-
 
 def get_config_path() -> Path:
     """Get the configuration path.