Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump org.apache.maven.plugins:maven-compiler-plugin from 3.12.1 to 3.13.0 #296

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 15, 2024

Bumps org.apache.maven.plugins:maven-compiler-plugin from 3.12.1 to 3.13.0.

Release notes

Sourced from org.apache.maven.plugins:maven-compiler-plugin's releases.

3.13.0

🚀 New features and improvements

📦 Dependency updates

📝 Documentation updates

👻 Maintenance

Commits
  • a1415aa [maven-release-plugin] prepare release maven-compiler-plugin-3.13.0
  • b2b9196 [MCOMPILER-574] Propagate cause of exception in AbstractCompilerMojo
  • 6d2ce5a [MCOMPILER-584] Refresh page - Using Non-Javac Compilers
  • eebad60 [MCOMPILER-585] Refresh plugins versions in ITs
  • ceacf68 [MCOMPILER-582] Automatic detection of release option for JDK < 9
  • 110293f [MCOMPILER-583] Require Maven 3.6.3
  • 90131df [MCOMPILER-575] Bump plexusCompilerVersion from 2.14.2 to 2.15.0 (#227)
  • 74cfc72 [MCOMPILER-548] JDK 21 throws annotations processing warning that can not be ...
  • f85aa27 Bump apache/maven-gh-actions-shared from 3 to 4
  • d59ef49 extract Maven 3.3.1 specific method call
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [org.apache.maven.plugins:maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.12.1 to 3.13.0.
- [Release notes](https://github.com/apache/maven-compiler-plugin/releases)
- [Commits](apache/maven-compiler-plugin@maven-compiler-plugin-3.12.1...maven-compiler-plugin-3.13.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-compiler-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner July 15, 2024 06:37
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 15, 2024
@dependabot dependabot bot requested review from vrudas, tomaszsmy and vuriaval and removed request for a team July 15, 2024 06:37
@jo-elimu
Copy link
Member

jo-elimu commented Jul 15, 2024

@coderabbitai What is the minimum Maven version required by version 3.13.0 of the maven-compiler-plugin?

I'm asking because our build system is using Apache Maven 3.6.1: https://jitpack.io/com/github/elimu-ai/model/model-2.0.70/build.log

Copy link

coderabbitai bot commented Jul 15, 2024

Tip

For best results, initiate chat on the files or code changes.

@jo-elimu The minimum Maven version required by version 3.13.0 of the maven-compiler-plugin is Maven 3.6.3. Since your build system is using Apache Maven 3.6.1, you would need to upgrade to at least Maven 3.6.3 to use this version of the plugin.

@jo-elimu
Copy link
Member

Since your build system is using Apache Maven 3.6.1, you would need to upgrade to at least Maven 3.6.3 to use this version of the plugin.

Thanks, @coderabbitai. Do you know if there is a way to configure JitPack to use a newer version of Apache Maven?

Copy link

coderabbitai bot commented Jul 15, 2024

Tip

For best results, initiate chat on the files or code changes.

@jo-elimu Yes, you can configure JitPack to use a newer version of Apache Maven by creating a jitpack.yml file in the root of your repository. Here is an example configuration to use Maven 3.6.3:

jdk:
  - openjdk8

maven:
  version: 3.6.3

This configuration will instruct JitPack to use Maven 3.6.3 for building your project.

@elimu-ai elimu-ai deleted a comment from coderabbitai bot Jul 15, 2024
@jo-elimu
Copy link
Member

Here is an example configuration to use Maven 3.6.3:

jdk:
  - openjdk8

maven:
  version: 3.6.3

@coderabbitai Okay. Can you create a committable suggestion to include that JitPack file as part of this pull request?

Copy link

coderabbitai bot commented Jul 15, 2024

Tip

For best results, initiate chat on the files or code changes.

@jo-elimu Here is the content for the jitpack.yml file to be included in this pull request:

jdk:
  - openjdk8

maven:
  version: 3.6.3

Please add this file to the root of your repository to configure JitPack to use Maven 3.6.3.

Unfortunately, I cannot create a committable suggestion directly, but you can add this file manually to the pull request.

@jo-elimu
Copy link
Member

jo-elimu commented Jul 15, 2024

Here is the content for the jitpack.yml file

@coderabbitai Can you change the openjdk version to 17?

Copy link

coderabbitai bot commented Jul 15, 2024

Tip

For best results, initiate chat on the files or code changes.

@jo-elimu Here is the updated content for the jitpack.yml file with openjdk version set to 17:

jdk:
  - openjdk17

maven:
  version: 3.6.3

Please add this file to the root of your repository to configure JitPack to use Maven 3.6.3 with OpenJDK 17.

@jo-elimu
Copy link
Member

Here is the updated content for the jitpack.yml file with openjdk version set to 17:

@coderabbitai And can you add sdk install maven as a before_install step?

Copy link

coderabbitai bot commented Jul 15, 2024

Tip

For best results, initiate chat on the files or code changes.

@jo-elimu Here is the updated content for the jitpack.yml file with the before_install step to run sdk install maven:

jdk:
  - openjdk17

maven:
  version: 3.6.3

before_install:
  - sdk install maven

Please add this file to the root of your repository to configure JitPack to use Maven 3.6.3 with OpenJDK 17 and install Maven using SDKMAN before the build process.

@jo-elimu
Copy link
Member

@coderabbitai And now remove the maven step, please?

Copy link

coderabbitai bot commented Jul 15, 2024

Tip

For best results, initiate chat on the files or code changes.

@jo-elimu Here is the updated content for the jitpack.yml file with the maven step removed:

jdk:
  - openjdk17

before_install:
  - sdk install maven

Please add this file to the root of your repository to configure JitPack to use OpenJDK 17 and install Maven using SDKMAN before the build process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant