[eclipse-iceoryx#264] Fix clang-tidy warnings

elfenpiff · Sep 9, 2024 · 27aecd9 · 27aecd9
1 parent c564240
commit 27aecd9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/iceoryx2-ffi/cxx/include/iox2/config_creation_error.hpp b/iceoryx2-ffi/cxx/include/iox2/config_creation_error.hpp
@@ -13,9 +13,11 @@
 #ifndef IOX2_CONFIG_CREATION_ERROR_HPP
 #define IOX2_CONFIG_CREATION_ERROR_HPP
 
+#include <cstdint>
+
 namespace iox2 {
 /// Failures occurring while creating a new [`Config`] object with [`Config::from_file()`].
-enum class ConfigCreationError {
+enum class ConfigCreationError : uint8_t {
     /// The config file could not be opened.
     FailedToOpenConfigFile,
     /// The config file could not be read.

diff --git a/iceoryx2-ffi/cxx/include/iox2/node_details.hpp b/iceoryx2-ffi/cxx/include/iox2/node_details.hpp
@@ -20,7 +20,7 @@ namespace iox2 {
 /// Contains details of a [`Node`].
 class NodeDetails {
   public:
-    NodeDetails(NodeName name, const Config& config);
+    NodeDetails(NodeName name, Config config);
 
     /// Returns a reference of the [`NodeName`].
     auto name() const -> const NodeName&;

diff --git a/iceoryx2-ffi/cxx/src/node_details.cpp b/iceoryx2-ffi/cxx/src/node_details.cpp
@@ -13,9 +13,9 @@
 #include "iox2/node_details.hpp"
 
 namespace iox2 {
-NodeDetails::NodeDetails(NodeName name, const Config& config)
+NodeDetails::NodeDetails(NodeName name, Config config)
     : m_node_name { std::move(name) }
-    , m_config { config } {
+    , m_config { std::move(config) } {
 }
 
 auto NodeDetails::name() const -> const NodeName& {