Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the incorrect rxjs import for
merge
is being used. When using this on Windows, I get aCannot call merge of undefined
(or something like that) here https://github.com/ccnokes/electron-spellchecker/blob/6181e409cd62ab1029b54aeceb2ae9375bc27232/src/spell-check-handler.js#L245.The issue is
import 'rxjs/add/operator/merge'
addsmerge
to the prototype, likeObservable_1.Observable.prototype.merge = merge_1.merge;
whereasimport 'rxjs/add/observable/merge';
adds it as a static method (which is how it's being used), likeObservable_1.Observable.merge = merge_1.merge;
It only occurs on Windows (maybe Linux too, didn't test it though) because
attachToInput
bails out early on mac (see https://github.com/ccnokes/electron-spellchecker/blob/6181e409cd62ab1029b54aeceb2ae9375bc27232/src/spell-check-handler.js#L211).I'm not sure how someone else didn't see this by now.... maybe I'm doing something wrong? But this fixes it for me on Windows.