Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct rx merge import #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ccnokes
Copy link

@ccnokes ccnokes commented Mar 28, 2018

It looks like the incorrect rxjs import for merge is being used. When using this on Windows, I get a Cannot call merge of undefined (or something like that) here https://github.com/ccnokes/electron-spellchecker/blob/6181e409cd62ab1029b54aeceb2ae9375bc27232/src/spell-check-handler.js#L245.

The issue is import 'rxjs/add/operator/merge' adds merge to the prototype, like Observable_1.Observable.prototype.merge = merge_1.merge; whereas import 'rxjs/add/observable/merge'; adds it as a static method (which is how it's being used), like Observable_1.Observable.merge = merge_1.merge;

It only occurs on Windows (maybe Linux too, didn't test it though) because attachToInput bails out early on mac (see https://github.com/ccnokes/electron-spellchecker/blob/6181e409cd62ab1029b54aeceb2ae9375bc27232/src/spell-check-handler.js#L211).

I'm not sure how someone else didn't see this by now.... maybe I'm doing something wrong? But this fixes it for me on Windows.

@partnerinflight
Copy link

Is this going to be merged in? Need this fix too.

@smithalan92
Copy link

@ccnokes @partnerinflight , I've had this issue as well, but only after transitioning to a new project and setting up electron spellchecker on it for some reason, on an old repo it works perfectly in an old repo for some reason.

After applying your patch in this PR manually, I'm still having an issue where, on Windows, spelling errors are not detected, I don't suppose either of you ran into this problem as well?

@partnerinflight
Copy link

Nope. Works for me. Except that I keep having to do a yarn install after every yarn upgrade, for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants