Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SEO): Generate time average urls for /map in sitemap #7413

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

VIKTORVAV99
Copy link
Member

Issue

In my previous PR I forgot to generate the links for /map.

Description

Adds a generator function for /map and includes the output in the final sitemap.

Preview

<?xml version="1.0" encoding="UTF-8"?><urlset xmlns="https://www.sitemaps.org/schemas/sitemap/0.9"><url><loc>https://app.electricitymaps.com/map/24h</loc></url><url><loc>https://app.electricitymaps.com/map/30d</loc></url><url><loc>https://app.electricitymaps.com/map/12mo</loc></url><url><loc>https://app.electricitymaps.com/map/all</loc></url><url><loc>https://app.electricitymaps.com/zone/AD/24h</loc></url><url><loc>https://app.electricitymaps.com/zone/AD/30d</loc></url><url><loc>https://app.electricitymaps.com/zone/AD/12mo</loc></url><url><loc>https://app.electricitymaps.com/zone/AD/all</loc></url><url>

Double check

  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

Copy link
Contributor

@cadeban cadeban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@VIKTORVAV99 VIKTORVAV99 enabled auto-merge (squash) November 14, 2024 15:05
@VIKTORVAV99 VIKTORVAV99 merged commit d7f3362 into master Nov 14, 2024
23 checks passed
@VIKTORVAV99 VIKTORVAV99 deleted the vik/sitemap_fix branch November 14, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend 🎨 javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants