Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parsers):Remove geothermal from NL parser #7394

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

annaib00
Copy link
Contributor

@annaib00 annaib00 commented Nov 11, 2024

Issue

Fix to issue #7386. Removing geothermal (type 9 in https://ned.nl/nl/handleiding-api) production from NL parser, as NL does not have any geothermal production. It is not added to unknown as we are already reporting more production than Eurostat and it could be geothermal heat production.

Description

Preview

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added parser python Pull requests that update Python code labels Nov 11, 2024
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

However do we have a plan for removing the geothermal data from the database?

It will not get overwritten as this will now return null values (not 0).

@annaib00
Copy link
Contributor Author

Ah, okay! No, we do not have a plan for that currently. Do you know if there are any nice way of doing this? Or should I just manually add a Geothermal value = 0 production i the parser?

@VIKTORVAV99
Copy link
Member

Ah, okay! No, we do not have a plan for that currently. Do you know if there are any nice way of doing this? Or should I just manually add a Geothermal value = 0 production i the parser?

I'll leave this up to @FelixDQ to decide, we have in the past been hesitant to hardcode values as it increases maintenance and risks being wrong in the future. But on the other hand I don't think the Netherlands will add geothermal electricity generation.

Otherwise you'll have to write a database migration to remove them.

@annaib00
Copy link
Contributor Author

Okay, @FelixDQ is on vacation this week so I will look more into it when he is back :)

@annaib00 annaib00 merged commit 56a2b3f into master Nov 11, 2024
22 checks passed
@annaib00 annaib00 deleted the annaboye/gmm-173-remove-geothermal-nl branch November 11, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants